django-payments icon indicating copy to clipboard operation
django-payments copied to clipboard

Add Paydirekt provider

Open devkral opened this issue 8 years ago • 3 comments

This adds a backend for paydirekt. It depends on some other pullrequests of mine: https://github.com/mirumee/django-payments/pull/148 https://github.com/mirumee/django-payments/pull/149

Sry for the long commit history. I required the backend for a project.

devkral avatar Oct 13 '17 13:10 devkral

Codecov Report

Merging #155 into master will increase coverage by 0.08%. The diff coverage is 79.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   79.13%   79.22%   +0.08%     
==========================================
  Files          27       29       +2     
  Lines        1649     1993     +344     
  Branches      190      234      +44     
==========================================
+ Hits         1305     1579     +274     
- Misses        245      292      +47     
- Partials       99      122      +23
Impacted Files Coverage Δ
payments/sofort/__init__.py 87.71% <ø> (-1.17%) :arrow_down:
payments/paypal/__init__.py 84.58% <100%> (ø) :arrow_up:
payments/core.py 83.07% <100%> (-4.62%) :arrow_down:
payments/authorizenet/__init__.py 79.54% <100%> (ø) :arrow_up:
payments/stripe/forms.py 96.92% <100%> (+0.09%) :arrow_up:
payments/braintree/forms.py 93.1% <100%> (+0.51%) :arrow_up:
payments/stripe/__init__.py 60% <100%> (ø) :arrow_up:
payments/dummy/__init__.py 81.13% <100%> (-5.67%) :arrow_down:
payments/cybersource/__init__.py 66.56% <100%> (+0.1%) :arrow_up:
payments/sagepay/__init__.py 90.76% <66.66%> (+2.05%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49c93aa...823028e. Read the comment docs.

codecov-io avatar Oct 17 '17 10:10 codecov-io

Thank you for this contribution. I think we'd prefer for new payment providers to live in their own packages. In fact we've discussed splitting the current main package.

Please take a look at https://github.com/esistgut/django-payments-bnlepos for an externally-maintained payment provider.

patrys avatar Oct 17 '17 11:10 patrys

good idea

devkral avatar Oct 18 '17 06:10 devkral