bigger decimal fields (20 digits) (hold more currencies)
8 decimal places to hold smallest btc unit 12 digits to hold cheaper currencies
https://github.com/mirumee/django-payments/issues/9
Codecov Report
Merging #153 into master will increase coverage by
0.01%. The diff coverage is100%.
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 79.13% 79.15% +0.01%
==========================================
Files 27 27
Lines 1649 1650 +1
Branches 190 190
==========================================
+ Hits 1305 1306 +1
Misses 245 245
Partials 99 99
| Impacted Files | Coverage Δ | |
|---|---|---|
| payments/models.py | 75% <100%> (+0.21%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 49c93aa...a75300c. Read the comment docs.
I am not sure if this pull request is a good idea. Most people just want two decimal_places and 12 digits.
anyway it is very domain specific (if you want to trade bitcoins or not)
I think this should be set by a variable as in #188