django-payments icon indicating copy to clipboard operation
django-payments copied to clipboard

bigger decimal fields (20 digits) (hold more currencies)

Open devkral opened this issue 8 years ago • 4 comments

8 decimal places to hold smallest btc unit 12 digits to hold cheaper currencies

https://github.com/mirumee/django-payments/issues/9

devkral avatar Oct 07 '17 09:10 devkral

Codecov Report

Merging #153 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   79.13%   79.15%   +0.01%     
==========================================
  Files          27       27              
  Lines        1649     1650       +1     
  Branches      190      190              
==========================================
+ Hits         1305     1306       +1     
  Misses        245      245              
  Partials       99       99
Impacted Files Coverage Δ
payments/models.py 75% <100%> (+0.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49c93aa...a75300c. Read the comment docs.

codecov-io avatar Oct 07 '17 09:10 codecov-io

I am not sure if this pull request is a good idea. Most people just want two decimal_places and 12 digits.

devkral avatar Oct 09 '17 21:10 devkral

anyway it is very domain specific (if you want to trade bitcoins or not)

devkral avatar Oct 09 '17 21:10 devkral

I think this should be set by a variable as in #188

Pacu2 avatar Sep 07 '18 12:09 Pacu2