django-payments icon indicating copy to clipboard operation
django-payments copied to clipboard

Alternate provider factory

Open ppython opened this issue 7 years ago • 5 comments

This patch provide an optional alternative to the current core.py/provider_factory method by setting an extra variable in the settings.

You could customize where the PAYMENTS_VARIANTS settings should be (DB instead of settings for exemple); have as many "stripe settings", isolated from one another.

I tried to provide as well a doc with this patch "doc/alternate_provider_factory.rst", it's a draft and unlinked from the other, as-is.

I needed to be able to configure a 'per entity in the DB' PAYMENT_VARIANTS list through the backend of my Django project. This patch helped me resolve this problem.

ppython avatar Nov 09 '16 03:11 ppython

Current coverage is 78.13% (diff: 28.57%)

Merging #121 into master will decrease coverage by 0.21%

@@             master       #121   diff @@
==========================================
  Files            29         29          
  Lines          1682       1688     +6   
  Methods           0          0          
  Messages          0          0          
  Branches        193        194     +1   
==========================================
+ Hits           1318       1319     +1   
- Misses          260        264     +4   
- Partials        104        105     +1   

Powered by Codecov. Last update 0582f98...15cf762

codecov-io avatar Nov 09 '16 03:11 codecov-io

This is a feature I really need, any progress on the merge?

esistgut avatar Nov 20 '16 11:11 esistgut

No progress here to report. We're thinking about an entirely different API for a future release of django-payments to better support other use cases.

patrys avatar Nov 21 '16 14:11 patrys

Excellent, though do you have an estimation of the target release date? weeks/months? (to keep track)

ppython avatar Nov 22 '16 18:11 ppython

I know it's been years, but I'd love to see this happen.

Would an updated PR for this be accepted?

WhyNotHugo avatar Oct 05 '20 18:10 WhyNotHugo