django-nose icon indicating copy to clipboard operation
django-nose copied to clipboard

Modernize Django transaction management for issue #226

Open akuchling opened this issue 8 years ago • 3 comments

I wanted to try the FastFixtureTestRunner, but found it didn't work with Django 1.8. I looked at the transaction-management features in Django 1.5 vs. 1.8 and came up with this set of changes.

This patch works well enough that my test suite of 255 tests ran successfully using FastFixtureTestRunner, but my testing wasn't exhaustive: for example, I didn't check that any fixture changes are rolled back as expected.

akuchling avatar Nov 11 '16 19:11 akuchling

Coverage Status

Coverage increased (+0.5%) to 68.845% when pulling 8e0b8231d37300bd6a4150710c6ec45a7c41de9d on akuchling:master into 3b9dad77d0440cace471aa43d77a4ba619f145bb on django-nose:master.

coveralls avatar Nov 11 '16 19:11 coveralls

I'm inclined to merge this because it works for you, but there are still no tests in the django-nose test suite that exercise FastFixtureTestRunner, so I'm not sure if it even works in Django 1.9, 1.10, etc.

jwhitlock avatar Nov 17 '16 14:11 jwhitlock

Maybe the tests can be imported from #258.

jwhitlock avatar Nov 17 '16 17:11 jwhitlock