django-floppyforms icon indicating copy to clipboard operation
django-floppyforms copied to clipboard

Remove DeprecationWarning in floppyforms 1.4?

Open EmilStenstrom opened this issue 10 years ago • 3 comments

In https://github.com/gregmuellegger/django-floppyforms/blob/master/floppyforms/models.py#L15 there's a deprecationwarning warning for changes in floppyforms 1.3. Since we're now in 1.4, maybe it's time to remove that warning?

EmilStenstrom avatar Jun 10 '15 15:06 EmilStenstrom

It would be good to remove that warning (and make that behavior the default.) This actually looks to be a significant change... according to a note in the floppyforms.__future__ file, those features require django 1.6+ – so making this change would mean dropping support for two versions of django.

melinath avatar Jun 15 '15 23:06 melinath

@gregmuellegger if that's a thing that we're okay with going ahead on, I'd be happy to make a PR.

melinath avatar Jun 15 '15 23:06 melinath

Yes, I think we are ok with dropping support for 1.5 and earlier. We could make it so that normal forms work just fine but if you try to subclasses ModelForm in 1.5, an exception is raised.

@melinath What's your opinion on this? A PR would be super super awesome. Thanks for stepping up! :beer:

gregmuellegger avatar Jun 22 '15 20:06 gregmuellegger