django-debug-toolbar icon indicating copy to clipboard operation
django-debug-toolbar copied to clipboard

Add show_toolbar_with_docker function for Docker IP handling

Open blingblin-g opened this issue 8 months ago • 1 comments

Description

  • Introduced a new function, show_toolbar_with_docker, to determine if the toolbar should be displayed when running inside Docker containers.
  • Updated installation documentation to reference the new function for Docker configurations.
  • Added a changelog entry for the new functionality.

Fixes #2113

Checklist:

  • [ ] I have added the relevant tests for this change.
  • [x] I have added an item to the Pending section of docs/changes.rst.

blingblin-g avatar Apr 09 '25 16:04 blingblin-g

Hi @blingblin-g I wanted to ask if you still intend to work on this and/or if there's anything I can do to help get this moving?

matthiask avatar Apr 29 '25 15:04 matthiask

Replaced by https://github.com/django-commons/django-debug-toolbar/pull/2153

matthiask avatar Jul 08 '25 14:07 matthiask

@matthiask

Oh, Sorry. I just noticed that the PR I was responsible for was closed just now after remaining unfinished for a long time. Could you please let me know if there is anything else that needs to be done regarding this task?

And I will make sure to share updates on my progress more frequently and inform you in advance if there are any delays.

Thank you.

blingblin-g avatar Jul 08 '25 15:07 blingblin-g

Hi @blingblin-g

Sure, I'd appreciate a review on the new PR over here: https://github.com/django-commons/django-debug-toolbar/pull/2153

I mostly only applied the suggested changes and submitted it myself again, still with you as the author.

matthiask avatar Jul 08 '25 15:07 matthiask

Great! I’d love to review it.

blingblin-g avatar Jul 08 '25 15:07 blingblin-g