django-debug-toolbar icon indicating copy to clipboard operation
django-debug-toolbar copied to clipboard
verified publisher icon jazzband

Track and display middleware time in the toolbar

Open earthcomfy opened this issue 1 year ago • 4 comments

Description

CPU time includes the debug toolbar's own time so this PR aims to track how long the middleware takes to run and display that time on the panel.

Fixes #1903

Checklist:

  • [x] I have added the relevant tests for this change.
  • [x] I have added an item to the Pending section of docs/changes.rst.

earthcomfy avatar Jan 03 '25 18:01 earthcomfy

Would it make sense to include a stat with the middleware time deducted from the total for the user? Or deduct it from the existing total?

robhudson avatar Jan 03 '25 19:01 robhudson

@robhudson the thinking I had earlier was that the toolbar changes the application so we shouldn't try to extract the toolbar itself from the timing.

tim-schilling avatar Jan 03 '25 22:01 tim-schilling

@earthcomfy do you have time to pick this back up? If not, @robhudson could ask a Djangonaut from the next session of Djangonaut Space to get it over the finish line.

tim-schilling avatar Sep 20 '25 13:09 tim-schilling

@tim-schilling Thanks for following up! I don’t think I’ll have time to return to this, so feel free to reassign it:)

earthcomfy avatar Sep 20 '25 15:09 earthcomfy