Actually use the Jinja2 template backend

Open matthiask opened this issue 1 year ago • 5 comments

Refs #1881.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Your commit message should include this information as well.

Fixes # (issue)

Checklist:

[ ] I have added the relevant tests for this change.
[ ] I have added an item to the Pending section of docs/changes.rst.

Feb 12 '24 10:02 matthiask

I pushed this forward for the next person. Here's my message from the last commit:

It instruments the single template render, but not the inherited templates and I'm guessing not the included templates either. I suspect we're going to have to patch jinja templates more robustly than relying on the django jinja backend template class.

Feb 19 '24 13:02 tim-schilling

@tim-schilling It would be great if we were able to inspect all of Jinja2's rendering but maybe that's harder because of Jinja2's template compilation, or what do you think? I didn't do much research here, so I'm basically just speculating.

I think what we have with your changes is already much better than the status quo. We could merge this, document the limitations and move on?

Apr 12 '24 13:04 matthiask