Serialize the panels
This is a draft PR. I'm keeping my on-going work in this branch. I found that my efforts to close #1807 and #1808 quickly spiraled into a major refactor of core logic.
This currently handles the SQLPanel which required the following changes:
- Drop
raw_paramsentirely. We'll need to serialize the parameters every time now so we can't rely on the original params - Refactor the SQL queries to use a
djdt_query_idwhich uniquely identifies each query. The SQL forms now reference this id and avoid passing SQL to be executed. - Move the formatting logic of SQL queries back to just before rendering. Otherwise we're rendering and storing the html in the store (I could be convinced I'm over-engineering for the future)
In addition this also changed our design for Panel
load_stats_from_store- Generates aPanelinstance with the passed in data.Panel.panel_idis now a class member to avoid needing to instantiate a panel to programatically get the panel id. With the new focus on fetching data for a specific panel given its ID, this became more of a need
I think this is at a point where we can add some async tests to confirm that this approach will work or not.
is this (somewhat) backwards compatible for third party panels?
While it doesn't break any documented APIs for the panel to function itself, this version is not backwards compatible since it loads the content for the panel from the store (render_panel view). That will need to be made backwards compatible to make this generally backwards compatible.
@matthiask I'm back to forcing everything that can't be serialized to JSON to a str. Otherwise we're trying to do it manually per panel which will involve a function that's likely going to do similar object and collection iteration as json.dumps().
This assumes we'll have some shared memory store for the cache hence the change to should_render_panels
from the above changes in consideration in consideration I was able able to run example with async calls
however I believe this async example would also work without serialised panels.
however I believe this async example would also work without serialised panels.
Why is that?