django-debug-toolbar icon indicating copy to clipboard operation
django-debug-toolbar copied to clipboard

Add Type hints to the codebase

Open leandrodesouzadev opened this issue 2 years ago • 9 comments

Is there any plans to add type hints to the codebase? As a newcomer to the project, i feel like there's a lot of places that could use type hints to better describe functions. I'm willing to do the job! :mechanical_arm:

leandrodesouzadev avatar Nov 11 '22 22:11 leandrodesouzadev

I don't have major any qualms against it. I think they're useful for method signatures and class members. However, I'm not committing getting to a point where we are going to say we need type hints on everything.

tim-schilling avatar Nov 11 '22 23:11 tim-schilling

@leandrodesouzadev looks like you have the go-ahead on this. I'd suggest doing it piecemeal so you don't end up with too many merge conflicts from long living branches. And so you don't burn yourself out. Thank you!

tim-schilling avatar Nov 12 '22 14:11 tim-schilling

Looks great, baby steps all the way. Maybe one module per pull request? How that sounds to you? Monday I will start working on this.

leandrodesouzadev avatar Nov 12 '22 22:11 leandrodesouzadev

That sounds good! Let us know if you need any help.

tim-schilling avatar Nov 12 '22 23:11 tim-schilling

@leandrodesouzadev circling back to this. How are things going?

tim-schilling avatar Oct 23 '23 00:10 tim-schilling

I haven't touched on the code base for a while now. I will try to do some other module or two this week and open the pull requests

leandrodesouzadev avatar Oct 23 '23 11:10 leandrodesouzadev