django-ddp icon indicating copy to clipboard operation
django-ddp copied to clipboard

Allow dddp to use the django defaults if settings.WSGI_APPLICATION exists but is None

Open imsdigital opened this issue 8 years ago • 3 comments

imsdigital avatar Apr 19 '16 15:04 imsdigital

Coverage Status

Coverage increased (+0.05%) to 64.115% when pulling ec94bb079a3230ac75d57e04678643eb5da34e9f on sgbirch:develop into 1e1954b06fe140346acea43582515991685e4e01 on django-ddp:develop.

coveralls avatar Apr 19 '16 15:04 coveralls

Looks good to me, but can you please explain why it was failing?

tysonclugg avatar Apr 29 '16 12:04 tysonclugg

Hi

The ddp code tests to see if the settings.WSGI_APPLICATION attribute exists, if not the default is used. In my case setting.WSGI_APPLICATION does exist but is set to None. I didn’t dig any further to see why the attribute existed.

I ended up going in another direction for now so feel free to reject the pull request if you don't like it.

Thanks for getting back to me and congrats on the new job.

Regards, Steve

On 29 Apr 2016, at 13:10, Tyson Clugg [email protected] wrote:

Looks good to me, but can you please explain why it was failing?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/django-ddp/django-ddp/pull/48#issuecomment-215695063

imsdigital avatar Apr 29 '16 12:04 imsdigital