django-dbbackup icon indicating copy to clipboard operation
django-dbbackup copied to clipboard

fix: restore tempfile created 0 B

Open rsommerard opened this issue 2 years ago • 3 comments

Type of PR (feature, enhancement, bug fix, etc.)

Description

File coming from external server like FTP are not well restored due to this error: Restore tempfile created 0 B

I don't know if the fix is the good way to do it.

Fixes #463

rsommerard avatar Oct 06 '22 10:10 rsommerard

Codecov Report

Merging #464 (76cd4ec) into master (af443c5) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
+ Coverage   92.15%   92.20%   +0.04%     
==========================================
  Files          16       16              
  Lines         676      680       +4     
  Branches      141      142       +1     
==========================================
+ Hits          623      627       +4     
  Misses         30       30              
  Partials       23       23              
Impacted Files Coverage Δ
dbbackup/management/commands/dbrestore.py 96.29% <100.00%> (+0.29%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 06 '22 10:10 codecov[bot]

Hey @rsommerard

Can you please add tests for this edge case?

Archmonger avatar Oct 10 '22 18:10 Archmonger

Marking as draft until tests are added.

Archmonger avatar Nov 02 '22 07:11 Archmonger