django-dbbackup icon indicating copy to clipboard operation
django-dbbackup copied to clipboard

Fix dbrestore on SQLite

Open Lokkook opened this issue 4 years ago • 5 comments
trafficstars

Adding @rgaiacs changes about restoring to sqlite db with newlines

Bug fix

Description

This change fix a pb when restoring fields that contains newlines.

Lokkook avatar Feb 11 '21 21:02 Lokkook

Related to #254 #258

johnthagen avatar Jan 09 '22 13:01 johnthagen

Codecov Report

Merging #383 (20d7287) into master (d187830) will decrease coverage by 0.57%. The diff coverage is 64.70%.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   90.87%   90.30%   -0.58%     
==========================================
  Files          19       19              
  Lines         855      866      +11     
  Branches      173      176       +3     
==========================================
+ Hits          777      782       +5     
- Misses         42       45       +3     
- Partials       36       39       +3     
Impacted Files Coverage Δ
dbbackup/db/sqlite.py 82.60% <64.70%> (-7.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d187830...20d7287. Read the comment docs.

codecov[bot] avatar Apr 27 '22 21:04 codecov[bot]

@johnthagen You mentioned something about the functional tests on this repo being iffy. Do you think that might be the reason why the test_create_dump_with_newline in this PR doesn't appear to run (according to the codecov hits)?

Unrelated note, I confirmed at least one issue on Windows appears to be related to gpg support. See dbbackup/tests/utils/add_public_gpg.

Archmonger avatar Apr 29 '22 07:04 Archmonger

You mentioned something about the functional tests on this repo being iffy.

I don't fully recall.

Unrelated note, I confirmed at least one issue on Windows appears to be related to gpg support.

Maybe *nix specific tests like gpg could be marked as skipped on Windows: https://docs.pytest.org/en/7.1.x/how-to/skipping.html#skipping-test-functions

johnthagen avatar Apr 29 '22 10:04 johnthagen

I'd need to confirm whether they should be skipped or not. It's very possible these tests failing is an indication that encryption support is broken on Windows.

Archmonger avatar Apr 29 '22 22:04 Archmonger