django-dbbackup
django-dbbackup copied to clipboard
Fix dbrestore on SQLite
Adding @rgaiacs changes about restoring to sqlite db with newlines
Bug fix
Description
This change fix a pb when restoring fields that contains newlines.
Related to #254 #258
Codecov Report
Merging #383 (20d7287) into master (d187830) will decrease coverage by
0.57%. The diff coverage is64.70%.
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 90.87% 90.30% -0.58%
==========================================
Files 19 19
Lines 855 866 +11
Branches 173 176 +3
==========================================
+ Hits 777 782 +5
- Misses 42 45 +3
- Partials 36 39 +3
| Impacted Files | Coverage Δ | |
|---|---|---|
| dbbackup/db/sqlite.py | 82.60% <64.70%> (-7.05%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d187830...20d7287. Read the comment docs.
@johnthagen You mentioned something about the functional tests on this repo being iffy. Do you think that might be the reason why the test_create_dump_with_newline in this PR doesn't appear to run (according to the codecov hits)?
Unrelated note, I confirmed at least one issue on Windows appears to be related to gpg support. See dbbackup/tests/utils/add_public_gpg.
You mentioned something about the functional tests on this repo being iffy.
I don't fully recall.
Unrelated note, I confirmed at least one issue on Windows appears to be related to gpg support.
Maybe *nix specific tests like gpg could be marked as skipped on Windows: https://docs.pytest.org/en/7.1.x/how-to/skipping.html#skipping-test-functions
I'd need to confirm whether they should be skipped or not. It's very possible these tests failing is an indication that encryption support is broken on Windows.