django-cookie-consent
django-cookie-consent copied to clipboard
jazzband
Remove smart_str
Can you elaborate on what breaks by using smart_str? As far as I can see it still exists in Django 4.1 and isn't deprecated either.
@sergei-maertens - I am not entirely sure if anything breaks. I just thought having smart_str() in the code was strange since you told me in the middleware PR that it was weird to even be there when we could have simply used str().
Right, it's been a while so I forgot about that 😛
I'm wondering now if this was somehow related with the bytestring setting name.
Possibly we don't even need any string casting at all - something to look into!
On Mon, 5 Sep 2022, 00:23 some1ataplace, @.***> wrote:
@sergei-maertens https://github.com/sergei-maertens - I am not entirely sure if anything breaks. I just thought having smart_str() in the code was strange since you told me in the middleware PR that it was weird to even be there when we could have simply used str().
— Reply to this email directly, view it on GitHub https://github.com/jazzband/django-cookie-consent/pull/63#issuecomment-1236425801, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKDJVVSPP6A7AHB524IBJLV4UOM5ANCNFSM5SARDDYQ . You are receiving this because you were mentioned.Message ID: @.***>