django-constance icon indicating copy to clipboard operation
django-constance copied to clipboard

refactor DatabaseBackend

Open sergei-iurchenko opened this issue 2 years ago • 2 comments

sergei-iurchenko avatar Nov 21 '23 22:11 sergei-iurchenko

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (bc9707d) 90.21% compared to head (133e685) 92.46%. Report is 1 commits behind head on master.

Files Patch % Lines
constance/backends/database.py 72.72% 6 Missing :warning:
constance/base.py 80.76% 3 Missing and 2 partials :warning:
constance/checks.py 70.00% 2 Missing and 1 partial :warning:
constance/backends/memory.py 0.00% 1 Missing and 1 partial :warning:
constance/backends/redisd.py 77.77% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   90.21%   92.46%   +2.24%     
==========================================
  Files          31       31              
  Lines        1053     1022      -31     
  Branches      156      147       -9     
==========================================
- Hits          950      945       -5     
+ Misses         68       49      -19     
+ Partials       35       28       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 22 '23 00:11 codecov[bot]

@sergei-iurchenko would you mind to work on this separately and create a PR when ready? (so we can close this)

camilonova avatar Mar 04 '24 17:03 camilonova