django-constance icon indicating copy to clipboard operation
django-constance copied to clipboard

"failed to update live settings" message

Open darkbarker opened this issue 3 years ago • 3 comments

if there are a lot of live settings, then no-noticeable error message causes serious inconvenience ( see issue #464 )

darkbarker avatar Jul 19 '22 16:07 darkbarker

If the form is not valid you will get a proper error message, no need to add an extra one.

camilonova avatar Aug 08 '22 13:08 camilonova

If the form is not valid you will get a proper error message, no need to add an extra one.

@camilonova sorry but you didnt understand what problem the patch solves, please read issue #464 where the problem is described in detail.

in short: error message (it exists, thats right) with many settings is absolutely unusable.

only difference between success and error is:

  • success: green banner
  • error: silent absence ("error message" is far at the bottom of the page)

imho this is a bad design, we have real cases when its not noticed

darkbarker avatar Aug 08 '22 13:08 darkbarker

@darkbarker Fix the build problems and I'll be happy to merge this.

camilonova avatar Aug 12 '22 21:08 camilonova

@camilonova i fixed build (tests, as i understand)

darkbarker avatar Sep 12 '22 13:09 darkbarker

@darkbarker Could you please rebuild .mo files after the translation change?

Mogost avatar Sep 12 '22 15:09 Mogost

Codecov Report

Merging #491 (f3bb3a5) into master (02c5fd5) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   83.16%   83.19%   +0.02%     
==========================================
  Files          16       16              
  Lines         600      601       +1     
  Branches      120      120              
==========================================
+ Hits          499      500       +1     
  Misses         67       67              
  Partials       34       34              
Impacted Files Coverage Δ
constance/admin.py 88.55% <100.00%> (+0.05%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 12 '22 15:09 codecov[bot]

@Mogost done, rebuilded (sorry for wait)

darkbarker avatar Oct 13 '22 10:10 darkbarker