django-constance
django-constance copied to clipboard
"failed to update live settings" message
if there are a lot of live settings, then no-noticeable error message causes serious inconvenience ( see issue #464 )
If the form is not valid you will get a proper error message, no need to add an extra one.
If the form is not valid you will get a proper error message, no need to add an extra one.
@camilonova sorry but you didnt understand what problem the patch solves, please read issue #464 where the problem is described in detail.
in short: error message (it exists, thats right) with many settings is absolutely unusable.
only difference between success and error is:
- success: green banner
- error: silent absence ("error message" is far at the bottom of the page)
imho this is a bad design, we have real cases when its not noticed
@darkbarker Fix the build problems and I'll be happy to merge this.
@camilonova i fixed build (tests, as i understand)
@darkbarker Could you please rebuild .mo files after the translation change?
Codecov Report
Merging #491 (f3bb3a5) into master (02c5fd5) will increase coverage by
0.02%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 83.16% 83.19% +0.02%
==========================================
Files 16 16
Lines 600 601 +1
Branches 120 120
==========================================
+ Hits 499 500 +1
Misses 67 67
Partials 34 34
| Impacted Files | Coverage Δ | |
|---|---|---|
| constance/admin.py | 88.55% <100.00%> (+0.05%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@Mogost done, rebuilded (sorry for wait)