django-celery-monitor icon indicating copy to clipboard operation
django-celery-monitor copied to clipboard

Allow tags fix for Django 2.0

Open madisvain opened this issue 6 years ago • 9 comments

This needs to be checked as I'm not 100% sure how the args and kwargs are meant to be rendering.

madisvain avatar Dec 07 '17 23:12 madisvain

I think you need to make your your PR pass the tests before it can be merged, right now it's breaking compatibility with Python 2.7

kedare avatar Dec 20 '17 11:12 kedare

I think the problem is that Django 2.0 gets installed on python 2.7? am I reading the travis results correctly? Django 2.0 is not supported on python 2.7

janezkranjc avatar Jan 02 '18 23:01 janezkranjc

I believe your tests are broken for python 2.7, it has nothing to do with this PR.

janezkranjc avatar Jan 02 '18 23:01 janezkranjc

@jezdez can you please retrigger the tests and consider merging this pull request, it would be greatly appreciated.

janezkranjc avatar Jan 04 '18 22:01 janezkranjc

@janezkranjc See my comment about rebasing on top of master, rerunning the tests won't be enough to fix it without the changes in master.

jezdez avatar Jan 05 '18 08:01 jezdez

Codecov Report

Merging #40 into master will increase coverage by 0.16%. The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   72.58%   72.74%   +0.16%     
==========================================
  Files           9        9              
  Lines         434      433       -1     
  Branches       54       54              
==========================================
  Hits          315      315              
+ Misses        114      113       -1     
  Partials        5        5
Impacted Files Coverage Δ
django_celery_monitor/admin.py 53.71% <16.66%> (ø) :arrow_up:
django_celery_monitor/utils.py 66.12% <33.33%> (+1.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ec1350...9835972. Read the comment docs.

codecov[bot] avatar Jan 10 '18 19:01 codecov[bot]

@jezdez should be good to go now. sorry for the late response.

madisvain avatar Jan 10 '18 19:01 madisvain

If #60 gets approved and merged, this issue can probably be closed.

pieterdd avatar Feb 14 '18 15:02 pieterdd

@jezdez what is your timeline about this PR?

keep that great work up!

eigenmannmartin avatar Nov 08 '18 10:11 eigenmannmartin