django-celery-monitor
django-celery-monitor copied to clipboard
Allow tags fix for Django 2.0
This needs to be checked as I'm not 100% sure how the args and kwargs are meant to be rendering.
I think you need to make your your PR pass the tests before it can be merged, right now it's breaking compatibility with Python 2.7
I think the problem is that Django 2.0 gets installed on python 2.7? am I reading the travis results correctly? Django 2.0 is not supported on python 2.7
I believe your tests are broken for python 2.7, it has nothing to do with this PR.
@jezdez can you please retrigger the tests and consider merging this pull request, it would be greatly appreciated.
@janezkranjc See my comment about rebasing on top of master, rerunning the tests won't be enough to fix it without the changes in master.
Codecov Report
Merging #40 into master will increase coverage by
0.16%
. The diff coverage is22.22%
.
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 72.58% 72.74% +0.16%
==========================================
Files 9 9
Lines 434 433 -1
Branches 54 54
==========================================
Hits 315 315
+ Misses 114 113 -1
Partials 5 5
Impacted Files | Coverage Δ | |
---|---|---|
django_celery_monitor/admin.py | 53.71% <16.66%> (ø) |
:arrow_up: |
django_celery_monitor/utils.py | 66.12% <33.33%> (+1.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6ec1350...9835972. Read the comment docs.
@jezdez should be good to go now. sorry for the late response.
If #60 gets approved and merged, this issue can probably be closed.
@jezdez what is your timeline about this PR?
keep that great work up!