django-avatar icon indicating copy to clipboard operation
django-avatar copied to clipboard

Published 20 hours ago • verified publisher icon jazzband

Fix gravatar fallback in render_primary view

Open fedetorre opened this issue 12 years ago • 2 comments

Hi jezdez, I'm starting to use your great django app for avatar associations to users. I've found this little bug in the render_primary view that not permit gravatar fallback if the user has no avatar.

If you want to merge it into the master branch I think it could be useful.

Kind regards, Federico

fedetorre avatar Jul 26 '13 14:07 fedetorre

I'm not following, what is this patch fixing?

jezdez avatar Sep 13 '13 14:09 jezdez

Basically if the AVATAR_GRAVATAR_BACKUP is enabled and the user has no avatar associated the render_primary view not redirect to the gravatar of the user but redirect to the default application avatar. With this patch the render_primary view redirect to the gravatar url if the option is enabled.

fedetorre avatar Sep 18 '13 08:09 fedetorre

@jezdez Are you still in the process of reviewing whether to include this?

johanneswilm avatar Aug 15 '22 10:08 johanneswilm

AVATAR_GRAVATAR_BACKUP setting has been removed in https://github.com/jazzband/django-avatar/pull/137 .

johanneswilm avatar Aug 16 '22 10:08 johanneswilm