django-auditlog
django-auditlog copied to clipboard
make field value retrieval slightly more robust
when no field 'default' attribute is present
credit to: https://github.com/stherrien
Fixes #169
Codecov Report
Merging #224 into master will not change coverage. The diff coverage is
0%
.
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 19 19
Lines 513 513
=======================================
Hits 423 423
Misses 90 90
Impacted Files | Coverage Δ | |
---|---|---|
src/auditlog/diff.py | 85.29% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c3fedc4...2a75517. Read the comment docs.
Codecov Report
Merging #224 into master will not change coverage. The diff coverage is
0.00%
.
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 19 19
Lines 513 513
=======================================
Hits 423 423
Misses 90 90
Impacted Files | Coverage Δ | |
---|---|---|
src/auditlog/diff.py | 85.29% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2aecef2...2a75517. Read the comment docs.
I can confirm that this issue still exists in master. forking and making this single line change has fixed the default onetoonerel error. If you'd like i can submit a new PR against current master. credit goes to bynare. https://github.com/mavericm1/django-auditlog
Hi @bynare. Thanks for your PR. Could you please rebase ? Thanks.
Hi there -- issue remains and I confirm that @euven one line change PR resolves. Without it I cannot loaddata as OneToOneField does not have a default attribute. Please advise whether I should maintain a local fork or if this PR from will be merged soon. Thank you!
Hi @hairypalm. Thanks for confirming that fix.
@euven Could you please:
- Rebase your patch
- Add a regression test
- Add a change log entry to https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md
@hairypalm it would be great if you could add a test function or code that helps us to add a test for it.
Added in https://github.com/jazzband/django-auditlog/commit/a56d0e6f784f3d0e1107f41c8c7a3f2423686c14