django-analytical
django-analytical copied to clipboard
jazzband
Add Liveinternet
Addition service Liveinternet. Several implementation options have been made as per the documentation:
- in the form of a single image combining the counter and the LiveInternet logo
- in the form of two images, one of which is a counter (transparent GIF size 1x1), and the other is the LiveInternet logo. This placement method will allow you to insert the code of the invisible counter at the beginning of the page, and the logo - where the design and content of the page allows.
Looks good to me! If it works on your end.
Can you please add tests to make the implementation complete?
Take a look at the other modules, if you need inspiration. It's easy and quick to do.
Thank you! 👍
Kind of implemented all the wishes 😊
Flake8 and isort found 3 minor issues, and some of your tests are failing. Can you fix that?
Flake8 и isort обнаружили 3 незначительные проблемы, и некоторые из ваших тестов не работают. Вы можете это исправить?
I don't have a lot of time right now, so I can't. As soon as I'm free, if I don't forget, I'll fix it.
I don't have a lot of time right now, so I can't. As soon as I'm free, if I don't forget, I'll fix it.
It's all good, take your time. Your contribution is good on track at the moment. Unfortunately, it's necessary to satisfy some basic code quality metrics. There's not much missing, though, really. Thank you for your understanding! Maybe set yourself a reminder. ⏱️