django-analytical icon indicating copy to clipboard operation
django-analytical copied to clipboard

Published 20 hours ago • verified publisher icon jazzband

Ask for consent - Matomo (Piwik)

Open jayhaluska opened this issue 6 years ago • 6 comments

This is a pull request to add the "Ask for consent" functionality from Matomo (Piwik). Especially relevant in the context of the new GDPR in Europe.

See: https://developer.matomo.org/guides/tracking-javascript-guide#asking-for-consent

jayhaluska avatar Jan 11 '19 22:01 jayhaluska

Fixes #141

bittner avatar Jan 11 '19 22:01 bittner

Merged the newest version of django-analytical into my fork.

I think this PR was forgotten, can we get it merged, @bittner?

jayhaluska avatar Jun 03 '19 22:06 jayhaluska

Probably it makes more sense now to add these changes to the newly created Matomo tag.

bittner avatar Jun 03 '19 22:06 bittner

I added the 'ask for consent' logic and documentation to the new matomo files and renamed everything accordingly.

But now the Travis CI check fails and I don't know why. Any suggestions?

jayhaluska avatar Jun 09 '19 20:06 jayhaluska

But now the Travis CI check fails and I don't know why. Any suggestions?

Flake8 complains about a missing newline in the test file:

./analytical/tests/test_tag_matomo.py:157:66: W292 no newline at end of file

It's a good idea to configure your IDE in a way that it ensures a final newline in every file you touch. Most modern IDEs have such a setting now.

bittner avatar Jun 12 '19 22:06 bittner

This PR needs to be rebased and its conflicts resolved. In addition, some review comments may still need to be addressed. But then it would be ready to be merged.

Want to give it another try?

bittner avatar Jul 11 '21 08:07 bittner