Jason Zhang
Jason Zhang
> what's the correct course of action here? > Amend the commit, rewrite the existing commit title and force push? Yes, the commit needs to be amended to pass the...
The first-line commit message needs to be less than 72 characters. Can you please update the commit? More detailed guideline can be found [here](https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-4-commit). Sorry, probably should've link that in...
@RedYetiDev Of course! Thanks for the heads up
I'll raise a backport PR for this tomorrow.
PR comments addressed. I have also updated the data structure comments in `fixed_queue` as it's no longer with `[empty]`
@benjamingr see [this thread](https://github.com/nodejs/node/issues/54186#issuecomment-2276785038). I think (and I agree) the idea is that we don't want to show it as a wanted behaviour. We fix it to avoid hard crashes.
Oh, I didn't know there are `test/known_issues`. I think it makes sense to place it there with a comment.
Actually, this may not be a known issue anymore - especially with this patch. I added a test case in `test-fixed-queue.js` to assert the queue no longer being holey. PTAL
@dosu how do I preserve the HTML response instead of the plain text response when using `load()`. Looks like it's not exposed like python version
pretty sure this is an unsupported feature in `html-to-text`, as the returned data are XML from Atalassian, and `html-to-text` is unable to do this. I propose to use `xmldom` to...