rust-cult-graphql-server icon indicating copy to clipboard operation
rust-cult-graphql-server copied to clipboard

Any minor improvments?

Open jayy-lmao opened this issue 4 years ago • 3 comments

@sync hope you're off to a good start with this year

I did something a bit like this for innovation day at Domain, and I want to provide this repo as an example for https://github.com/benawad who has shown interest in this sort of thing.

If you have the time, could I pretty pwease get your opinion on where it could be improved? There's a bit of inspiration from your hex architecture stuff with ports -- but ultimately I want to keep this relatively simple and cut down on boilerplate.

Thanks amigo ❤️

jayy-lmao avatar Jan 07 '21 01:01 jayy-lmao

you can use sqlx to migrate and setup your db that would be nice :-) look for sqlx migrate

sync avatar Jan 07 '21 03:01 sync

Is there a reason you used dataloader-rs over async_graphql::dataloader? I assume the latter didn't exist back when this repository was started, but their changelog doesn't go back far enough. Or does dataloader-rs have actual advantages?

cschmatzler avatar Jun 04 '21 22:06 cschmatzler

Hey @cschmatzler, thanks for dropping by! Yeah as you suspected, when I wrote this I don't think I spotted async_graphql::dataloader. It may have been there, but if it was I didn't see it in the docs, examples, and didn't dig deep enough to find it. The usage of dataloader-rs was recycling my work from https://github.com/jayy-lmao/rust-graphql-docker in order to provide an analogous example for async-graphql but I am very open to replacing it with async_graphql::dataloader in order to have more consistency within the repo ☺️

jayy-lmao avatar Jun 07 '21 01:06 jayy-lmao