hotkeys-js icon indicating copy to clipboard operation
hotkeys-js copied to clipboard

Convert project to TypeScript

Open jennings opened this issue 5 years ago • 4 comments

I saw in #66 there was interest in converting this project to TypeScript. Would you be willing to take this as a pull request or do you only want to do that work yourself?

We had to fork this project to fix an issue for ourselves, and when we did so we also converted it to TypeScript. Since I’ve done it once, it might be easy to do it again and contribute it back if I can get the build process converted too.

I can’t guarantee I’ll have time, but if there’s no interest in taking it as a contribution I didn’t want to spend time on it.

Thanks for the great library!

jennings avatar Jan 22 '20 20:01 jennings

@jennings Willing to accept pull request.

jaywcjlove avatar Jan 23 '20 15:01 jaywcjlove

pls no, just use vanilla js i would like to be able to just do:

<script type="module">
  import hotkey from cdn
<script>

you can accomplish the same level of typing from using comments and using default arguments https://www.dandoescode.com/blog/using-typescript-without-typescript/

if anything include a type definition file and don't convert everything to typescript

jimmywarting avatar Sep 25 '20 13:09 jimmywarting

Won't the compiled files be available from the cdn as well?

danielpza avatar Jan 06 '21 00:01 danielpza

@jimmywarting What does it have to do with TS? the library build is always JS output.

adi518 avatar Aug 25 '21 22:08 adi518