hotkeys-js
hotkeys-js copied to clipboard
Convert project to TypeScript
I saw in #66 there was interest in converting this project to TypeScript. Would you be willing to take this as a pull request or do you only want to do that work yourself?
We had to fork this project to fix an issue for ourselves, and when we did so we also converted it to TypeScript. Since I’ve done it once, it might be easy to do it again and contribute it back if I can get the build process converted too.
I can’t guarantee I’ll have time, but if there’s no interest in taking it as a contribution I didn’t want to spend time on it.
Thanks for the great library!
@jennings Willing to accept pull request.
pls no, just use vanilla js i would like to be able to just do:
<script type="module">
import hotkey from cdn
<script>
you can accomplish the same level of typing from using comments and using default arguments https://www.dandoescode.com/blog/using-typescript-without-typescript/
if anything include a type definition file and don't convert everything to typescript
Won't the compiled files be available from the cdn as well?
@jimmywarting What does it have to do with TS? the library build is always JS output.