John Vandenberg

Results 965 comments of John Vandenberg

Hi @Jondeen , I have looked through https://github.com/image-rs/image-tiff/compare/master...Jondeen:image-tiff:tiled_multipage and it looks like there are no breaking changes required. It may not be beautiful, but it works. IMO you should run...

The installer could not find a compiler (gcc). The two relevant lines of the error are ``` unable to execute 'gcc': No such file or directory error: command 'gcc' failed...

I was trying to package this as an rpm, and noticed that some of the tests in the last release fail because of missing data. I see some new data...

Awesome. Thanks. OpenSUSE here; I'll borrow those happily, but I notice that .spec is using GitHub archive rather than sdist. I'm hoping the next sdist will be better.

@eclipseo , my spec is at https://build.opensuse.org/package/show/home:jayvdb:rpm/python-patool . It has a few extra patches , and a different subset of programs due to programs missing in openSUSE . I'll submit...

Compiling the published crate using rust stable results in ``` ... Compiling Boa v0.5.1 error[E0282]: type annotations needed --> /home/jayvdb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/Boa-0.5.1/src/lib/builtins/array.rs:23:11 | 23 | array.borrow().set_internal_slot( | ^^^^^^ ----------------- type must be...

This would be very handy; has anyone looked at https://github.com/wolever/pip2pi/pull/65 to see if it is save-able.

You are correct. I've described the problem a bit at https://stackoverflow.com/questions/75052086/how-to-locate-the-cargo-lock-from-build-rs , along with a solution to use https://crates.io/crates/project-root , which needs to be used with https://docs.rs/built/latest/built/fn.write_built_file_with_opts.html in order to...

i.e. something like ```rust fn main() { let dest = std::path::Path::new(&env::var("OUT_DIR").expect("OUT_DIR not set")).join("built.rs"); let workspace_root = ...get_workspace_root()...; built::write_built_file_with_opts( Some(&workspace_root), &dest, ).expect("Failed to acquire build-time information"); } ``` where `get_workspace_root` is...

Thanks @lukaslueg , I've tested `master` - it works well.