John Vandenberg comments

Results 1947 comments of


                                            John Vandenberg

cached-property dependency is unnecessarily high

I checked 1.0.0 and it also works. https://travis-ci.org/jayvdb/coala/builds/489869767

Emphasize that you should never use the evil green button in the docs

This issue reserved for Google Code-in task [5228756865122304](https://codein.withgoogle.com/dashboard/tasks/5228756865122304).

Replace coala-header.png with SVG and CSS

Re-assigning as an SVG is a better approach

Coala's AGPL coverage

Hi @briankhsieh , No, AGPL covers only coala code in the repository, not any generated code / modifications . And each coala bear has metadata for the license of their...

Coala's AGPL coverage

Yes, that is correct. Sorry that the docs havent been updated yet. I'll assign myself, and tackle it this week sometime.

newcomers_guide.rst: add a warning for not to use git pull CLI command

@shriram98 , this one is reserved for Google Code-in . Please find another one on https://coala.io/new

newcomers_guide.rst: add a warning for not to use git pull CLI command

This issue reserved for Google Code-in task [5682493584834560](https://codein.withgoogle.com/dashboard/tasks/5682493584834560).

download_cached_file should retry if there is a http error code

Note unlike #3803 , this is not a regression as the pre-requests code didn't do this.

download_cached_file should retry if there is a http error code

Note that `requests` has native `max_retries` logic which we can use. It [requires](http://stackoverflow.com/questions/15431044/can-i-set-max-retries-for-requests-request) working at the requests session & adapter level. I've also looked for a sane requests wrapper which...

download_cached_file should retry if there is a http error code

Note, if there is a retry, then surely there needs to be a new status code check somewhere, but this doesnt appear to be documented anywhere in requests; see https://github.com/coala/coala/pull/3805#discussion_r103427077.