John Vandenberg

Results 1061 comments of John Vandenberg

py2many isnt a Python code bug detector. We shouldnt have code for invalid Python. It is unreachable by any half-sane test code.

This is not a v0.3 blocker.

> But I'm sure there is python code out there like this which expects a specific exception and breaks when a different one (AssertionError) is thrown. This is completely irrelevant,...

```diff - if 0 < len(node.args) < 4: raise AstTypeError("range() with unexpected arguments") + assert 0 < len(node.args) < 4, "range() call with unexpected arguments" ``` The `assert` always executed...

I haven't found a way to change the default "Cognitive Complexity" from 15 to say 20. From my use of SonarCloud at work, this shouldnt cause a problem, as new...

https://sonarcloud.io/summary/overall?id=jayvdb_py2many now has a C rating for reliability, and A for maintainability (165 smells, with only a few in `tests/test_*.py` so I haven't excluded those). To achieve that, I set...

https://sonarcloud.io/project/overview?id=jayvdb_py2many updated, with `tests/dir_cases/**` added to exclusions

The main reason to be running sonarcloud is to have a persistent record of the test coverage of the project, and other metrics, and to ensure new code mets the...

`bool()` is also valid ```py >>> print(bool()) False ``` It currently creates the following exception which is fixed by https://github.com/adsharma/py2many/pull/390 ```py py2many/clike.py:676: in _dispatch return self._small_dispatch_map[fname](node, vargs) _ _ _...

Perhaps we should do this automatically on startup if `format.jl` was not found? Or fail on startup and provide instructions to install it. ping @MiguelMarcelino