Jay Narale
Jay Narale
cc: @Yuhta @yingsu00
cc: @Yuhta @yingsu00 @pranjalssh @rui-mo
I added a new array of array test, we should not need the parquetReaderTests
@Yuhta can you please review?
Thats strange, it passes in the CI https://github.com/facebookincubator/velox/actions/runs/8619946770/job/23625777461?pr=9187 maybe its flaky, I will take another look
@Yuhta Can you please try again? I updated that test to follow the convention of the test file. Maybe that was flaky
Sorry for the late message. I was on a vacation, I am not sure how to enable ASAN but I will try. Shouldn't this be enabled in the CI by...
It does pass locally for me with asan enabled. I added ``` set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=address") ``` to the makefile, and needed to add libasan.so.8 to the ldconfig
Couldn't repro locally with the debug build as well ` ctest -j ${NUM_THREADS} -VV --output-on-failure -R "parquet_table_scan"` command used to run
Was the array test the only failure? If so it could be that there could be some issue in the test file and I can remove this test.