ghw icon indicating copy to clipboard operation
ghw copied to clipboard

Could not collect windows disk partition infomation

Open Zzorz opened this issue 2 years ago • 1 comments

There is a bug in ghw/pkg/block/block_windows.go https://github.com/jaypipes/ghw/blob/f38192d6ca0e6d937e83bda5fd17f4870b4db014/pkg/block/block_windows.go#L118 The comparison between * uint32 and * uint32 would be wrong in this circumstance.

Bug can be fixed with method below:

...
if *diskdrive.Index == *diskpartition.DiskIndex {
    ...
}

Zzorz avatar Aug 13 '21 07:08 Zzorz

@Zzorz I am so sorry for the delay in getting back to you on this. The notification on this bug report just slipped through my inbox :(

I will look into a fix for this shortly. Thanks very much!

jaypipes avatar Oct 19 '21 14:10 jaypipes

Any chance this fix could get merged? Thank you for looking!

zackbloom avatar Feb 02 '23 18:02 zackbloom

@zackbloom @Zzorz please see https://github.com/jaypipes/ghw/pull/330

jaypipes avatar Feb 06 '23 13:02 jaypipes

Fix is in https://github.com/jaypipes/ghw/releases/tag/v0.10.0

jaypipes avatar Feb 06 '23 13:02 jaypipes

Thank you so much!

zackbloom avatar Feb 06 '23 15:02 zackbloom