Phil Dibowitz
Phil Dibowitz
the above can be fixed by changing line 352 from: ``` if 'Innodb_max_trx_id' in status: ``` to ``` if 'Innodb_max_trx_id' in status and 'Innodb_purge_trx_id' in status: ``` I'll try to...
nevermind. PR attached. :)
Currently we use a "custom" flavor of markdown with Kramdown, it's the default with a few monkeypatches. But Kramdown supports GH-flavorered markdown, and I've long wanted to move us to...
> Awesome relaxed Is there anything else you (or others) would particularly like to see changed or implemented in what I've done so far? > > I'll start working on...
Sorry for the lack of response, February was kinda crazy and I dropped a bunch of stuff. Did you see my comment above though?
Code and tests look great, pending tests passing. Went ahead and kicked those off. Thanks!
DCO is still failing - make sure *all* commits on the branch are signed-off.
I'm merging, but would you mind submitting another PR to add documentation for this feature please?
Also thanks for this awesome feature and for sticking with the long review process!
or `#` for root prompts. Seems reasonable. Though this isn't a new rule, just an RFE on an existing rule; will update accordingly.