kodi-addon-soundcloud icon indicating copy to clipboard operation
kodi-addon-soundcloud copied to clipboard

Introduce local My Favourites for SoundCloud

Open mr-pineapple-nz opened this issue 3 years ago • 9 comments

As it's not likely that SoundCloud will release new application client ids to access it's APIs, (especially authentication) this change allows the user to store users and tracks under a special favorite menu.

Happy to discuss further changes/improvements

mr-pineapple-nz avatar Jan 15 '21 05:01 mr-pineapple-nz

not likely that SoundCloud will release new application client ids to access it's APIs

I think we can just use the client ID from the SoundCloud Android app for this. I'll test it this month. If it doesn't work, I'll merge your PR.

jaylinski avatar Jan 20 '21 22:01 jaylinski

not likely that SoundCloud will release new application client ids to access it's APIs

I think we can just use the client ID from the SoundCloud Android app for this. I'll test it this month. If it doesn't work, I'll merge your PR.

Cool, let me know how it goes, or if I can help you with that.

mr-pineapple-nz avatar Jan 25 '21 04:01 mr-pineapple-nz

@mr-pineapple-nz Short status update: I'm currently busy implementing some stuff in the Vimeo add-on. I did not forget about your PR. I'll try to find some time next week.

jaylinski avatar Feb 06 '21 21:02 jaylinski

OK. I tried your idea regarding the client id, not much success :(

mr-pineapple-nz avatar Feb 08 '21 06:02 mr-pineapple-nz

@mr-pineapple-nz I'm done with the Vimeo add-on and will take a look this week. Would it be ok for you if this feature was only implemented for Kodi 19 (Matrix)? Or are you still using Kodi 18?

jaylinski avatar Feb 23 '21 20:02 jaylinski

@mr-pineapple-nz I'm done with the Vimeo add-on and will take a look this week. Would it be ok for you if this feature was only implemented for Kodi 19 (Matrix)? Or are you still using Kodi 18?

@jaylinski Can be merged to v19 of course. I haven't upgraded yet but will do soon.

mr-pineapple-nz avatar Feb 23 '21 23:02 mr-pineapple-nz

@mr-pineapple-nz I'm done with the Vimeo add-on and will take a look this week. Would it be ok for you if this feature was only implemented for Kodi 19 (Matrix)? Or are you still using Kodi 18?

@jaylinski Can be merged to v19 of course. I haven't upgraded yet but will do soon.

@jaylinski is there any update on this? Do you need anything else from me?

mr-pineapple-nz avatar Mar 30 '21 05:03 mr-pineapple-nz

@mr-pineapple-nz Sorry for not responding for so long. Good news: I finally found some motivation to dig into this issue again and started to reverse the mobile-app API in order to implement a login: https://github.com/jaylinski/kodi-addon-soundcloud/pull/53/files

I'm pretty confident that I can get the login to work and lined out my plans for it here: https://github.com/jaylinski/kodi-addon-soundcloud/issues/40 Since I did the same for another plugin, it should be pretty straight forward. You can subscribe to issue #40 in order to see my progress.

I'll keep this PR open for now.

jaylinski avatar Jun 06 '21 21:06 jaylinski

@mr-pineapple-nz Sorry for not responding for so long. Good news: I finally found some motivation to dig into this issue again and started to reverse the mobile-app API in order to implement a login: https://github.com/jaylinski/kodi-addon-soundcloud/pull/53/files

I'm pretty confident that I can get the login to work and lined out my plans for it here: #40 Since I did the same for another plugin, it should be pretty straight forward. You can subscribe to issue #40 in order to see my progress.

I'll keep this PR open for now.

cool @jaylinski . Let me know if I can help, I'm happy to do so :)

mr-pineapple-nz avatar Jun 08 '21 05:06 mr-pineapple-nz