rn-draw icon indicating copy to clipboard operation
rn-draw copied to clipboard

Simplify Path and Curves

Open gaboelnuevo opened this issue 5 years ago • 6 comments

Please test this proposition. @jayeszee

Have a good day!

gaboelnuevo avatar Jun 11 '19 03:06 gaboelnuevo

https://github.com/jayeszee/rn-draw/issues/14

gaboelnuevo avatar Jun 11 '19 03:06 gaboelnuevo

Hi, I have tested it and its working fine.

I have made some changes into the RNDraw and a test code.

I'm more like a C programmer, I'm new with react, expo and this stuff.

I will try to commit my ideas, maybe it can help with something else.

The commit is here https://github.com/softov/rn-soft-drawer

Image-1

softov avatar Jun 13 '19 09:06 softov

I also made a PR #17 for #14, using your code with mine (already in production).

Is like your modifications made it more fluid.

https://github.com/jayeszee/rn-draw/pull/17

softov avatar Jun 13 '19 09:06 softov

Thanks for testing. @softov Interesting Snack.

I think is more clean make a separated PR merge this (https://github.com/jayeszee/rn-draw/pull/15) PR first, Publish, And then publish new changes (like https://github.com/jayeszee/rn-draw/pull/17) with a compatibility note and breaking changes warning.

PD: You take my changes but you don't you reflect my commits in your changes. :(

gaboelnuevo avatar Jun 13 '19 16:06 gaboelnuevo

Sorry for that. It’s because I have made this a few days ago. I just read what you do and copy that.

I will be replacing my commit with a new one.

Let’s just wait for jayeszee to pull your changes. If not I will maintain my fork and maybe I will create a new repository rn-soft-draw with my intents. Because I’m already using this in production.

There is some changes and functions I want to add, I just need time.

What do you think? You can email me at [email protected] or WhatsApp so we can chat about that?

softov avatar Jun 14 '19 01:06 softov

I have made another, please check it.

softov avatar Jun 14 '19 14:06 softov