letra-extension icon indicating copy to clipboard operation
letra-extension copied to clipboard

Serbian

Open lxmarinkovic opened this issue 2 years ago • 3 comments

✅ New Quote Checklist

  • [ ] The quote(s) added are in alphabetical order by author's first name and not ❌ duplicates.
  • [ ] The quote(s) added are about learning a foreign language.
  • [ ] The sentence attribute does not have inner quotation marks, and is ended with a period.
  • [ ] Copy pasted the raw JSON quotes.json file to JSONLint and made sure that the modified JSON file is valid.

✅ New Language Checklist

  • [x] There is ❌ no assigned issue or pull request for this new language.
  • [x] ➕ Added a new JSON object in the server/data/languages.json file.
  • [x] Added the voice 🎤 attribute supported by ResponsiveVoice API.
  • [x] Added the flag 🏳 attribute in the format of the twemoji-awesome CSS syntax.
  • [x] Added the romanization attribute for appropriate languages.
  • [x] ➕ Created the {language.json} file inside the server/data/words folder containing the list of the 3000 words.
  • [x] Removed duplicates and noted 🗒 them in the Pull Request.
  • [x] Increment currentLanguagesCount in client/src/store/index.js
  • [x] Add new language in README.md

lxmarinkovic avatar Jan 17 '22 19:01 lxmarinkovic

Someone is attempting to deploy a commit to a Personal Account owned by @jayehernandez on Vercel.

@jayehernandez first needs to authorize it.

vercel[bot] avatar Jan 17 '22 19:01 vercel[bot]

Hi @jayehernandez, I have just started with Serbian translation. Looking forward to continuing and finishing it 💯 :)

lxmarinkovic avatar Jan 17 '22 19:01 lxmarinkovic

Hi, @lxmarinkovic thanks for your contribution. As you might have seen from the Readme, this project is currently not worked upon actively, so you have to wait until it resumes back in order to get your PR merged or worked upon.

The changes look good to me. I hope you understand and thanks again for your work!

Kvaibhav01 avatar Jan 18 '22 08:01 Kvaibhav01

@all-contributors add @lxmarinkovic for Translation

jayehernandez avatar Oct 19 '22 11:10 jayehernandez

@jayehernandez

I've put up a pull request to add @lxmarinkovic! :tada:

allcontributors[bot] avatar Oct 19 '22 11:10 allcontributors[bot]