Jay Rogers

Results 232 comments of Jay Rogers

# šŸ‘Øā€šŸ”¬ Test this PR You can test the latest changes on our [serversideup/php-dev repo on DockerHub](https://hub.docker.com/r/serversideup/php-dev/tags?name=523-): ``` serversideup/php-dev:523-* ``` (Any thing prefixed with `523` [the PR number] is built...

> Will test this PR-Image in my ~30 Client sites I wouldn't call them "stable" yet, but it is working for one of our very complicated client testing sites: -...

That's super strange! I've been running this in very low spec servers and haven't noticed any issues. Some of them are even stacked with multiple apps on them (using our...

# āš ļø Important update **This PR is being closed in favor of #283**. I played GitHub Shuffle and I had to do another release before this release. I also worked...

So this is the culprit: https://github.com/serversideup/docker-php/blob/825625bfee3fa2849328ba3386a2e8cb3b63b8da/src/common/usr/local/bin/docker-php-serversideup-entrypoint#L42-L54 **Line 47** is where it gets executed. I forget the exact reason why we did it this way, but if there is a better...

I wonder if @szepeviktor would have any opinions on this as he is a shell wizard šŸ§™

Thanks! Makes sense. I guess my question is **Which method should we follow? Existing shell or subshell?** In the case of allowing people to run their own scripts, should we...

Thanks @szepeviktor! @rburgst: Are you okay with just using `return 0` instead of `exit 0`?

I am all ears on proposals. I have @cappuc [who submitted a PR](https://github.com/serversideup/docker-php/pull/464) to have it be `return 0` and it seems like you're suggesting it to be `exit 0`....

So I've been looking into this deeper and trying to use AI to help guide a direction with this, it had a helpful explanation as I asked it about this...