Jay Klehr

Results 20 issues of Jay Klehr

Ran into some code that was doing this: ```php while (@ob_end_clean()) {} ``` Safe defines `ob_end_clean` as a `void` return: https://github.com/thecodingmachine/safe/blob/master/generated/outcontrol.php#L22 However, `ob_end_clean` will return `true` when it successfully clears...

Was testing using Critters to inline some critical CSS and noticed that it's inserting HTML/HEAD/BODY tags into output files that don't already have these tags. These files intentionally don't have...

help wanted

I was looking at a comparison between some browscap parsers and noticed a useragent that doesn't parse the same way in browscap-php 3.0 and PHP's native get_browser function (php 7.0.15)...

In #385, `mktime` was deprecated in this lib, but technically I think `mktime` will still return `false` in an unusual situation: https://github.com/php/php-src/blob/master/ext/date/php_date.c#L1156 Before digging into php-src to see if it...

We recently ran into a situation where we're sending thousands of "jobs" that hit this screenshot service one after another (in our tests we were actually hitting the service with...

This is sort of similar to the issue I ran into with the Mockery plugin (https://github.com/vimeo/psalm/issues/1537) in that a `class_alias` is being used to conditionally alias one class to another....

FX 3.0 spits out an error if link.styleSheet is undefined. Checking if undefined and then setting to empty object before rawCssText gets set.

I re-did the git submodule command for the webfont medical icon set which ended up changing the `.gitmodules` file slightly and added the directory for the icons. Ran the build...

icons/add

We upgraded tailwind-variants to the 1.0 release (and subsequently bumped tailwind-merge to match the dependency defined, which is 3.0.x) and discovered that conflicting classes weren't being removed as they were...