Jay Conrod

Results 194 comments of Jay Conrod

A gentle ping for review. I sent this just before Bazelcon, so I apologize for the awkward timing.

Thanks for reviewing! https://github.com/bazelbuild/examples/pull/519 has the example code for this, so let me know if you have feedback for that one, too.

Looks good! Thanks again for reviewing and publishing.

Sorry, there's no way to control whether warnings are printed or not. Loosely related: #499. when `go_repository` invokes Gazelle, it should probably either error out with a descriptive message or...

Sorry for the slow response; very backlogged right now. I basically agree with @achew22: `glob` is good to avoid, but we should probably support generating and merging `glob` expressions.

@fmeum @linzhp What do you think of this suggestion? This introduces a minor incompatibility, but the new behavior would be simpler, in line with what most users would expect and...

This feels like `go_default_library` to me: so named because `//foo/bar:bar` was expected to have the import path `example.com/foo/bar/bar`, but everyone actually expected `example.com/foo/bar`. Fixing that was worth it, though it...

Could the job that runs Nogo first write the [Nogo JSON configuration file](https://github.com/bazel-contrib/rules_go/blob/master/go/nogo.rst#configuring-analyzers), indicating which files should be reported? That seems like the best way to handle this for now,...

@prestonvanloon Does #1956 solve your problem with non-empty archives? It should be released soon. About setting up cross-compilation, I wrote [Configuring a custom C toolchain](https://github.com/bazelbuild/rules_go/blob/master/go/crosstool.rst) some time ago. It doesn't...

Before reviewing this, I think we need a clearer description of the problem being solved. Please open an issue explaining that and link here. What are the absolute paths coming...