Jayce Slesar
Jayce Slesar
> I’d love to get it in as I’m using it in derived code we have here and I’m sure it’s helpful, but I’m not sure what changes I need...
when these are in will they contribute to speed increases for metadata only operations like counts and counts within partitions?
Any insight as to when this will be available with sink_* methods?
Ah there is more too this because https://github.com/mkdocs/mkdocs-click/blob/master/mkdocs_click/_docs.py#L104 looks like a decent amount of those. Do we want to support a special option for each one of those checks?
yeah would need to specify options for the following: 1. `command_class` (already implemented in existing commits) 1. `multicommand_class` https://github.com/mkdocs/mkdocs-click/blob/master/mkdocs_click/_docs.py#L104 1. `option_class` https://github.com/mkdocs/mkdocs-click/blob/master/mkdocs_click/_docs.py#L219 1. `choice_class` https://github.com/mkdocs/mkdocs-click/blob/master/mkdocs_click/_docs.py#L268 1. `datetime_class` https://github.com/mkdocs/mkdocs-click/blob/master/mkdocs_click/_docs.py#L274 1. `intrange_class`...
> Are you still interested in adding support for other custom classes like Context? I actually require this now as well! I am! Are you looking at just async-click? I...
yeah literally just commenting out https://github.com/mkdocs/mkdocs-click/blob/master/mkdocs_click/_loader.py#L20 seems to work fine so might be worth just adding the async click as an optional mkdocs dependency here and dealing with it that...
hmmm I added ```py @pytest.mark.integration @pytest.mark.parametrize("test_catalog", CATALOGS) def test_slow_dots( test_catalog: Catalog, table_schema_simple: Schema, table_name: str, database_name: str ) -> None: identifier = (database_name, table_name) test_catalog.create_namespace(database_name) tbl = test_catalog.create_table(identifier, table_schema_simple) df...
We can delete mountains of code if this is done correctly.... What about a strategy of each test_catalog providing a suite of basic fixtures that can be passed into a...