Jay

Results 857 comments of Jay

@andrey-k Btw, you can remove the `caching` flag. That was just to ensure that while you were changing these options, you weren't still using the cached build.

I should also mention this for anybody testing the `commonjs` option, the best way to ensure that the results are not cached is not remove your `node_modules` directory and try...

If folks can confirm that the above solves their issue, we can either document this or add a check while building.

@Luke-Rhodes-RDSLE4 How come removing `commonjs` isn't an option for your case?

Pushed a new release that shows a warning if `commonjs` is detected. Also added a note to the README. https://github.com/AnomalyInnovations/serverless-bundle/releases/tag/v4.0.0 https://github.com/AnomalyInnovations/serverless-bundle#module-and-targets

Hi @dror-weiss I guess I'm not totally clear on the issue here. This is excluding the list of files that we don't want to type check. In this case all...

Thanks for the repo. I get that the issue is happening. I'd like to know why it's happening. I unfortunately can't accept a PR if I don't understand the issue...

Yup taking a look. A couple of comments/questions: - Your approach of excluding specific packages should be applied to JS as well? This isn't TS specific correct? - I guess...

@ggrantrowberry What was the issue you ran into with the new beta? That should address this issue. You can checkout the `Knex.js` instructions in the README - https://github.com/AnomalyInnovations/serverless-bundle/tree/beta#advanced-options

@blai Thanks for investigating and posting this. Agreed, that we need specific examples. Do you mind contributing one for this case? Btw, we have this note in the README and...