James Addison
James Addison
> The single [test failure](https://github.com/sphinx-doc/sphinx/actions/runs/19748819758/job/56588233131?pr=14107#step:10:5014) seems unrelated -- perhaps an overfitted regex number-of-decimal-places expectation (expecting exactly three digits where perhaps shorter values are possible). > > Edit: fixup: overfittered is...
A concern/suggestion about the identifiers for the aggregated errors in particular: could we keep their string values the same as the existing, single-source error identifiers? The reason I'm thinking/asking about...
Ok, thank you @stephanegigandet. I'm doing a quick audit of the [Mirabelle `distri-qual.sh` script](https://github.com/openfoodfacts/openfoodfacts-infrastructure/blob/97b12831d29a94ddc9c1446019edb9a660b040d5/scripts/mirabelle/distri-qual.sh) to check the downstream usage of the tags. The [`recipe-estimator-metrics`](https://github.com/openfoodfacts/recipe-estimator-metrics) and [`off-product-environmental-impact`](https://github.com/openfoodfacts/off-product-environmental-impact) projects also reference some...
I'm a little busy for the rest of this week, but I will attempt to resume the downstream effect review of the tags tomorrow.
Self-quoting: > I'm a little busy for the rest of this week, but I will attempt to resume the downstream effect review of the tags tomorrow. I didn't get around...
Partial progress on downstream-effect review: **[openfoodfacts-infrastructure](https://github.com/openfoodfacts/openfoodfacts-infrastructure)** * `data-quality.sh`: this solely compares `data_quality_errors_tags` for non-empty values (e.g. [here](https://github.com/openfoodfacts/openfoodfacts-infrastructure/blob/855f7c6b7e3257098ce603517f75836c9954b83a/scripts/mirabelle/data-quality.sh#L131)). So I anticipate no problems in this script; the additional prefixes will not...
An additional, related question: the `id1` hyperlink target previously emitted for the `figure` is now placed into a LaTeX `\phantomsection`; is that something we should be concerned about? (both @jfbu...
Thanks @AA-Turner - agreed, makes sense; I'm not completely confident about the approach taken in #13610.
> > This can be fixed by catching the error in [`tools/code-sample-minimizer.js`](https://github.com/eslint/eslint/blob/v9.36.0/tools/code-sample-minimizer.js#L94). > > Good idea, I prepared [#19961](https://github.com/eslint/eslint/issues/19961). That should at least make fuzz testing useful until we figure...
cc @pgjones (sorry to nag; just keen to make sure this fixup is included in `quart` also)