pilmoji icon indicating copy to clipboard operation
pilmoji copied to clipboard

update Pilmoji.text function to add support of align and anchor

Open madifaya opened this issue 1 year ago • 7 comments

Hello !

I propose a solution to implement the parameters "anchor" and "align" into Pilmoji.text.

this should be linked to Issues :

  • https://github.com/jay3332/pilmoji/issues/14
  • https://github.com/jay3332/pilmoji/issues/23

madifaya avatar Dec 15 '23 17:12 madifaya

👍

zsilverzweig avatar Feb 05 '24 18:02 zsilverzweig

@jay3332

madifaya avatar Feb 06 '24 10:02 madifaya

@jay3332 could this be merged?

LevaniVashadze avatar May 07 '24 13:05 LevaniVashadze

maybe @vertyco, @owocado , @annihilatorrrr or @WitherredAway can merge too ?

madifaya avatar May 07 '24 13:05 madifaya

maybe @vertyco, @owocado , @annihilatorrrr or @WitherredAway can merge too ?

I'm not a maintainer

WitherredAway avatar May 07 '24 15:05 WitherredAway

maybe @vertyco, @owocado , @annihilatorrrr or @WitherredAway can merge too ?

I'm not a maintainer.

annihilatorrrr avatar May 07 '24 16:05 annihilatorrrr

pip install git+https://github.com/madifaya/pilmoji.git@add-support-text-align Until then this works, but merging would be really useful

LevaniVashadze avatar May 07 '24 16:05 LevaniVashadze

@madifaya Hey I noticed that this change is breaking the spacing between lines when changing it and also it messes up the emojis position when not changing the spacing, for example if the multiline text is: Hello\ntest😉 it breaks the emojis position only if the line doesn't contain a full height character.

LevaniVashadze avatar May 23 '24 14:05 LevaniVashadze

@madifaya Hey I noticed that this change is breaking the spacing between lines when changing it and also it messes up the emojis position when not changing the spacing, for example if the multiline text is: Hello\ntest😉 it breaks the emojis position only if the line doesn't contain a full height character.

I didn't understand what breaks sorry. could you send a picture of the break and/or maybe the implementation that breaks please?

madifaya avatar May 29 '24 11:05 madifaya

@madifaya Hey I noticed that this change is breaking the spacing between lines when changing it and also it messes up the emojis position when not changing the spacing, for example if the multiline text is: Hello\ntest😉 it breaks the emojis position only if the line doesn't contain a full height character.

I didn't understand what breaks sorry. could you send a picture of the break and/or maybe the implementation that breaks please?

Hey the emojis are misaligned, i tried it with apple emojis and they were misaligned in your version(they were too low)

LevaniVashadze avatar May 29 '24 12:05 LevaniVashadze