zapatos icon indicating copy to clipboard operation
zapatos copied to clipboard

Fix transactions returning bad connections to the pool

Open jfrconley opened this issue 2 years ago • 2 comments

Currently, errors in transactions do not get propagated to the pool. This means failed connections will get returned to the pool, effectively poisoning the well. This change simply passes exceptions back to the pool when they occur, allowing the connection to be dropped.

@jawj

jfrconley avatar Jun 13 '22 22:06 jfrconley

@jfrconley I'm curious what the impact of this bug/fix is. Can you elaborate?

john-trashlab avatar Jan 21 '23 02:01 john-trashlab

I'm sorry to see I never responded to this. @jfrconley Is there any chance you could put together a simple test case that demonstrates the problem and how your patch solves it?

jawj avatar Jan 23 '23 14:01 jawj