list.js
list.js copied to clipboard
Prevent pagination buttons from scrolling to top
Fixes a regression introduced by #499, causing the browser to scroll to the top of the page when the pagination buttons are clicked.
Codecov Report
Merging #750 (9dcb779) into master (d32c85d) will decrease coverage by
0.11%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #750 +/- ##
==========================================
- Coverage 93.54% 93.43% -0.12%
==========================================
Files 19 19
Lines 837 838 +1
Branches 199 199
==========================================
Hits 783 783
- Misses 38 39 +1
Partials 16 16
Impacted Files | Coverage Δ | |
---|---|---|
src/pagination.js | 90.90% <0.00%> (-1.40%) |
:arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
The initial commit prevented the click event's execution of for all the List's objects. This causes problems e.g. when the list contains clickable elements such as checkboxes, which become unusable.