django-river icon indicating copy to clipboard operation
django-river copied to clipboard

Fix cyclic graph state explosion

Open CapCap opened this issue 3 years ago • 4 comments

When states cycle A->B->A->B, there are a truly exponential number of states that get created. Two such cycles are enough to cause 10s + loading times for pages, and realistically will easily break altogether.

Big thank you to @JohnieBraaf for the fixes here.

This should fix https://github.com/javrasya/django-river/issues/188 and https://github.com/javrasya/django-river/issues/120

The problem is discussed in detail in the above issues.

CapCap avatar May 13 '21 17:05 CapCap

Thank you for creating this PR @CapCap

JohnieBraaf avatar Jun 11 '21 07:06 JohnieBraaf

Any time soon to have this fix on the codebase? Thanks

pupubird avatar Sep 03 '21 19:09 pupubird

Unlikely, author believes this is a feature not a bug, despite performance quickly exponentially declining when used

CapCap avatar Sep 04 '21 06:09 CapCap

Ah I see! No worries

pupubird avatar Sep 04 '21 12:09 pupubird