Javi Martín

Results 287 comments of Javi Martín

Looks like both Safari and Firefox have added support for this element in 2021. Combined with the fact that a year has gone by since the last update, now at...

Adding a validation rule so no emails are allowed as usernames could be fine. The tricky part is that there might be records in the `users` table using emails as...

Great, since we're touching this part of the application, I think we'll add some changes to fix an accessibility issue we've got here. We say "With you account you can...

Hi, @tonekk :smile:. It might be related to the fact that the field `tokens` is a `json` field and that seems to be causing issues when querying the users table...

Hi, @tonekk :smile:. I've just had a first look at the pull request. You've certainly done a lot of work; thanks for that! Before doing a review in detail, here...

Hi, @tonekk :smile:. Naming is super-hard, indeed, particularly if we take into account that naming in this project is already inconsistent in some places :sweat_smile:. Regarding the question about voting...

@tonekk By the way, I see there are some tests failing. The reason seems to be the `include GraphqlDevise::Concerns::Model` in the users model, which probably adds a validation making email...

A possible workaround could be disabling the default callbacks (`config.default_callbacks = false` in the devise auth token initializer). Not sure about the possible implications, since that would also mean that...

@tonekk We've got an open pull request to [Bump graphql from 1.12.14 to 1.13.15](https://github.com/consul/consul/pull/4955). Since we don't want to interfere with the task you're currently doing, what do you prefer?...

Reopening since it's got the "Bug" label.