Javi Martín

Results 287 comments of Javi Martín

Hi, @coslajohn :smile:. Thank you for the report and the fix! :tada: Before we review it, could you have a look at the [messages reported by our linters](https://github.com/consuldemocracy/consuldemocracy/actions/runs/10041099109/job/27748458110?pr=5616)? :pray:

Hi, @coslajohn :smile:. > I have extended the code now to add layers to the map so that geozones can be toggled on and off. This is useful when geozones...

Oh, I see, thanks @coslajohn! I've updated the pull request to include the latest changes in the master branch and changed the last commit in order to load the layers...

Hi, @coslajohn :smile:. I've added some tests for the GeoJSON validation and done some refactorings and small fixes in order to make the tests pass (in particular, we're now supporting...

> Hmmm.... taking out the FeatureCollection wrapping probably doesn't make any functional difference as any geojson which is being normalized is only ever likely to be a single feature. However,...

Hi, @coslajohn :smile:. Thanks for the pull request! I know this is still a work in progress, but here are some preliminary comments. > Next enhancement will be to read...

@coslajohn Thanks a lot! We really appreciate it. We'll take it from here and have a look at the tests. It'll take a while, though (August is a slow month...

Hi, @coslajohn :smile:. Luckily, this is an easy one! The problem is that Zeitwerk (which we included in version 2.2.0 as part of the upgrade to Rails 7) expects the...

Hi, @coslajohn :smile:. I see that here we're using generic names like `RestrictIp` and `allowed_ips` and a concern that might be included in other controllers. Does it mean that you...

Hi, @DominikPeters :smile:. Thank you very much for your contribution! I'm afraid it usually takes us a while to review a pull request. Sorry for that! :pray: In this particular...