Javier Julio comments

Results 197 comments of


                                            Javier Julio

form.has_many cannot hide 'remove button' on new records

I would accept a PR for that. There may be something for it already.

Show all batch action names in the batch action selector's title

I'm not sure this makes any sense to me. You want to append a delimited list of the drop down options to the drop down button label so they don't...

Disable COUNT(*) for filtered collections

There is a PR ready for this that needs an update. Thank you.

Remove inherited_resources

I figure removing this dependency would be too major as we likely use a lot from InheritedResources. If it's doable though I would be open to that and accept PRs....

Intermittent spec failure when testing with webpacker

I had to disable the webpacker build in CI temporarily because it now always fails but I’m not sure what the cause or fix is. Any help would be appreciated....

Intermittent spec failure when testing with webpacker

@tagliala thank you. I've approved that PR and just rebased it now that the Codecov migration in #7853 has been merged. Yes, you're very likely right about the secrets/code coverage...

Append DSL for print footer in index_as_table.

Thank you. Sorry, I don't have any plans to support this so I'm closing this out. This may be better suited to a custom index-as component instead. Something to consider...

Add 'not' options to filter

We would accept a PR for this. Thank you.

Allow different new and edit rules in authorization adapters

@timwis can you please rebase this and push? I will accept this change if its backwards compatible with Pundit and suggested ActiveAdmin defaults since I think others should be able...

Allow different new and edit rules in authorization adapters

@timwis that sounds great, thank you! I really appreciate you following up. Once you are ready with that case and further testing, we will get this in.