javicacheiro
javicacheiro
Integration testing already performed against a password protected redis server.
Yes, of course, I was not sure the best way but this was also my initial thinking. Do you want me to create different PR for each of them so...
No problem! In the meanwhile I have added the possibility you mentioned for empty options when using default values.
I did a rebase to integrate the fix for the new jwcrypto versions so tests do not break. I hope to not have created a mess.
Now is hard to see what are the commits specific to this PR. Support for empty options is here: https://github.com/novnc/websockify/pull/518/commits/8eeef0f6d77be3e6e8174a04a521a29b7a4c74cb
It depends on the external modules that you use and how verbose they are. In the case of websockify it does not increase the logging messages much and it is...
Just run the original and the new code with the "--verbose" option and the difference in the output are the following two lines (for one connection): ``` response from redis...
Sorry, I forgot to include in the previous comment the output we would get without the "--verbose" option: ``` TokenRedis backend initilized (3.3.3.3:6379) WebSocket server settings: - Listen on 1.1.1.1:9444...
Fixed the problem with the rebase. Everything looks fine now and as, a side effect, we now have a rebase to the latest upstream. Really needed after so many months.