dnotebook-react icon indicating copy to clipboard operation
dnotebook-react copied to clipboard

CSS Framework [Suggestion]

Open steveoni opened this issue 4 years ago • 11 comments

@AceTheCreator I will suggest we make use of tailwind css to ease prototyping. I've set up the tailwind configuration and everything needed to enable tailwind

steveoni avatar Jan 22 '21 20:01 steveoni

@steveoni i don't think that'll be necessary because the UI has been done already. I was planning on submitting a pull request today but I'm having issue with my Pc. The only thing remaining is just the default functions output. E.g. Load_csv, load_package e.t.c.

AceTheCreator avatar Jan 22 '21 20:01 AceTheCreator

ok, if that so, you can just pull and discard my changes.

and for the load_csv and load_package, we can easily copy and paste that from the Dnotebook itself into this current version.

steveoni avatar Jan 22 '21 21:01 steveoni

@steveoni sorry for the delay on the project. I just got my system fixed today, so i'll hop on the project ASAP

AceTheCreator avatar Feb 01 '21 22:02 AceTheCreator

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

AceTheCreator avatar Mar 09 '21 21:03 AceTheCreator

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one. Screenshot from 2021-03-09 22-53-54

AceTheCreator avatar Mar 09 '21 21:03 AceTheCreator

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

Hi @AceTheCreator , how you doing, hope it is not something too critical. Great to hear from you again

steveoni avatar Mar 14 '21 10:03 steveoni

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one. Screenshot from 2021-03-09 22-53-54

That will be okay. But we can also have a spinner to indicate the file is loading. Awesome work. you create a pull request for this

steveoni avatar Mar 14 '21 10:03 steveoni

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

Hi @AceTheCreator , how you doing, hope it is not something too critical. Great to hear from you again

Thanks man

AceTheCreator avatar Mar 15 '21 00:03 AceTheCreator

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one. Screenshot from 2021-03-09 22-53-54

That will be okay. But we can also have a spinner to indicate the file is loading. Awesome work. you create a pull request for this

Ok. I'll implement the features mentioned above and create a pull request.

AceTheCreator avatar Mar 15 '21 00:03 AceTheCreator

@steveoni implemented the feature mentioned above.

AceTheCreator avatar Mar 18 '21 13:03 AceTheCreator

@AceTheCreator My bad, I'm just seeing this update now. Great work! I just saw your PR. @steveoni will review and merge.

risenW avatar Mar 18 '21 14:03 risenW