danfojs icon indicating copy to clipboard operation
danfojs copied to clipboard

fix: fix for tests

Open ekynoxe opened this issue 1 year ago • 4 comments

Browser tests are filing as the bundle file Karma tries to load is not found and frontend tests fail to even start.

It looks like the issue was introduced by #516 and I'm not sure what it aimed to solve since the esbuild generated file is bundle.esm.js, whilst the webpack one was bundle-esm.js (simply bundle.js with this PR.)

I think the file rename was unnecessary, so I've reverted that.

We could also update the karma configuration file to use bundle-esm.js, it fixes the browser tests as well.

ekynoxe avatar Oct 05 '23 11:10 ekynoxe

@ekynoxe did you also check if it fix this issue https://github.com/javascriptdata/danfojs/issues/514 as suggested by https://github.com/javascriptdata/danfojs/pull/516

steveoni avatar Oct 07 '23 10:10 steveoni

@steveoni for me, when linking danfojs from a new vue app, master doesn't work. I get the same error describe in #594 . So this particular PR doesn't fix #514, but my PR #604 does. I'll update the description that it also works with a new Vuew project.

Screenshot 2023-10-09 at 09 31 54

ekynoxe avatar Oct 09 '23 08:10 ekynoxe

Has anyone figured out how to fix this issue? I was really looking forward to using this library in our production pipeline, but I can't remove Vite unfortunately and local hacks/fixes are a no go either.

rchavp avatar Dec 12 '23 15:12 rchavp

Has anyone figured out how to fix this issue? I was really looking forward to using this library in our production pipeline, but I can't remove Vite unfortunately and local hacks/fixes are a no go either.

I'm afraid we've had zero feedback from the maintainers on either of my PRs, so we can't do much anymore.

ekynoxe avatar Dec 18 '23 09:12 ekynoxe