pt.javascript.info icon indicating copy to clipboard operation
pt.javascript.info copied to clipboard

Published 20 hours ago • verified publisher icon javascript-tutorial

Loops: while and for

Open alvar-o opened this issue 6 years ago • 9 comments

I'm sorry for the mess in the commits. I got my credentials right and here's the work on the chapter "Loops: while and for".

alvar-o avatar Oct 21 '19 20:10 alvar-o

Error: the article already has PR number in the Progress Issue #1, it's 50 :interrobang:

javascript-translate-bot avatar Oct 21 '19 20:10 javascript-translate-bot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: alvar-o
:x: Álvaro Antonio

Álvaro Antonio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 21 '19 20:10 CLAassistant

@alvar-o Hi, I'll have to take a look at the bot messages first. Thanks.

odsantos avatar Oct 21 '19 23:10 odsantos

@alvar-o Hi, I'll have to take a look at the bot messages first. Thanks.

I had an issue with the credentials configured in my git, I thought I had solved it but my previous commits still show with the wrong credentials. The only way to work this out seems to be to delete my fork and start a new one, then make a new pull request. Let me know if this is needed! :)

alvar-o avatar Oct 22 '19 13:10 alvar-o

Hi @alvar-o, if you can delete the fork, make a new one and a new PR with only one file I would appreciate.

You might be considering to clone your fork to your computer.

If you already have a cloned fork in your computer, please delete that folder before cloning your new fork. But, before deleting anything make a backup copy of your translation (save it on a file) for an easy copy/paste later.

On the PR, do not also forget to accept the license.

Thanks.

odsantos avatar Dec 16 '19 19:12 odsantos

Hi @alvar-o is this still in progress? If so, could you remove the conflicts, otherwise would you please inform of your unavailability? Thank you.

odsantos avatar Nov 27 '20 02:11 odsantos

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

javascript-translate-bot avatar Jul 23 '21 18:07 javascript-translate-bot

Hello @herbertpdl , only maintainers should review the pull requests on this repository. It even has conflicts, so it is expected to be outdated.

odsantos avatar Jul 23 '21 19:07 odsantos

Hello @herbertpdl ,

It seems you no longer are working on this.

I am afraid I am releasing this lesson for another person within a week.

Thanks, Osvaldo.

odsantos avatar Dec 14 '22 22:12 odsantos